feature: support dapr state api #377

zach030 · 2021-12-28T13:19:29Z

What this PR does:

feature:

support dapr state api
integrate dapr API with default_api
add some converter codes
implement QueryStateAlpha1 and add some missing error-msg consts

Which issue(s) this PR fixes:

Fixes #361

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Signed-off-by: zach <zachchou016@gmail.com>

seeflood · 2021-12-29T01:06:26Z

Thanks for your contribution !
Please check and fix the CI failure.
@wenxuwan Could u help review this PR?

wenxuwan · 2021-12-29T02:16:24Z

Thanks for your contribution ! Please check and fix the CI failure. @wenxuwan Could u help review this PR?

ok

wenxuwan · 2021-12-29T14:22:05Z

@zach030 please fix the failed ci first

zach030 · 2021-12-29T15:17:07Z

@zach030 please fix the failed ci first

Yes. But I don't know the reason of CI failure now 🥲

wenxuwan · 2021-12-30T02:09:44Z

@zach030 please fix the failed ci first

Yes. But I don't know the reason of CI failure now 🥲

should be cause by cel-go version, you can check cel-go version in the go.sum

zach030 · 2021-12-30T10:17:14Z

@zach030 please fix the failed ci first

Yes. But I don't know the reason of CI failure now 🥲

should be cause by cel-go version, you can check cel-go version in the go.sum

我查了一下，我的这次修改引入了对dapr的依赖：github.com/dapr/dapr v1.5.1
dapr依赖的cel-go的版本是github.com/google/cel-go v0.7.3 ，而mosn依赖的版本是github.com/google/cel-go v0.5.1

然后我对比了一下v0.7.3和v0.5.1 google/cel-go@v0.5.1...v0.7.3
common/types/duration.go 两个版本里有比较大的差异

wenxuwan · 2021-12-31T02:57:23Z

@zach030 please fix the failed ci first

Yes. But I don't know the reason of CI failure now 🥲

should be cause by cel-go version, you can check cel-go version in the go.sum

我查了一下，我的这次修改引入了对dapr的依赖：github.com/dapr/dapr v1.5.1 dapr依赖的cel-go的版本是github.com/google/cel-go v0.7.3 ，而mosn依赖的版本是github.com/google/cel-go v0.5.1

然后我对比了一下v0.7.3和v0.5.1 google/cel-go@v0.5.1...v0.7.3 common/types/duration.go 两个版本里有比较大的差异

替换成0.5.1看dapr那边会不会报错

Signed-off-by: zach <zachchou016@gmail.com>

codecov · 2022-01-01T16:13:26Z

Codecov Report

Merging #377 (d1f3b25) into main (a9b4598) will decrease coverage by 3.40%.
The diff coverage is 22.02%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   57.61%   54.21%   -3.41%     
==========================================
  Files         107      108       +1     
  Lines        5762     5921     +159     
==========================================
- Hits         3320     3210     -110     
- Misses       2105     2382     +277     
+ Partials      337      329       -8

Impacted Files	Coverage Δ
pkg/grpc/dapr/dapr_api_state.go	`0.00% <0.00%> (ø)`
pkg/grpc/default_api/api.go	`73.06% <ø> (-2.74%)`	⬇️
pkg/runtime/state/compatibility.go	`100.00% <ø> (+25.45%)`	⬆️
pkg/grpc/default_api/api_state.go	`80.18% <80.18%> (ø)`
components/configstores/apollo/change_listener.go	`74.00% <0.00%> (-6.00%)`	⬇️
components/rpc/invoker/mosn/channel/xchannel.go	`80.64% <0.00%> (-3.23%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b4598...d1f3b25. Read the comment docs.

zach030 · 2022-01-04T02:32:36Z

@wenxuwan already fixed ci failure

wenxuwan · 2022-01-04T02:41:58Z

@wenxuwan already fixed ci failure

ok， i will review asap

pkg/grpc/default_api/api_state.go

Signed-off-by: zach <zachchou016@gmail.com>

wenxuwan

LGTM

go.mod

pkg/grpc/dapr/dapr_api_state.go

Signed-off-by: zach <zachchou016@gmail.com>

…nto feature_dapr_state_api Signed-off-by: zach <zachchou016@gmail.com>

zach030 · 2022-01-11T11:05:33Z

@seeflood 移除了加密部分的代码，还有对 github.com/dapr/dapr v1.5.1的依赖，目前看来没有版本冲突的问题了

seeflood · 2022-01-13T07:43:09Z

FYI, I removed some unused code,e.g. pkg/converter/state.go

seeflood

lgtm

wenxuwan

LGTM

* dapr/state:add get/save state dapr api Signed-off-by: zach <zachchou016@gmail.com> * dapr/state:add query/delete state Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:replace cel-go with v0.5.1 Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:fix state api ut Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:init slice with cap Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api: remove encrypt dependency Signed-off-by: zach <zachchou016@gmail.com> * remove unused code * add comments Co-authored-by: seeflood <349895584@qq.com> # Conflicts: # pkg/grpc/dapr/dapr_api_state.go # pkg/grpc/dapr/dapr_api_unimplement.go # pkg/grpc/default_api/api.go # pkg/grpc/default_api/api_state.go

* dapr/state:add get/save state dapr api Signed-off-by: zach <zachchou016@gmail.com> * dapr/state:add query/delete state Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:replace cel-go with v0.5.1 Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:fix state api ut Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api:init slice with cap Signed-off-by: zach <zachchou016@gmail.com> * dapr/state_api: remove encrypt dependency Signed-off-by: zach <zachchou016@gmail.com> * remove unused code * add comments Co-authored-by: seeflood <349895584@qq.com>

zach030 added 2 commits December 28, 2021 09:43

dapr/state:add get/save state dapr api

6740c7a

Signed-off-by: zach <zachchou016@gmail.com>

dapr/state:add query/delete state

94c03dc

Signed-off-by: zach <zachchou016@gmail.com>

mosn-community-bot bot added cla:yes size/XXL labels Dec 28, 2021

wenxuwan self-requested a review December 29, 2021 02:13

zach030 added 2 commits January 1, 2022 23:30

dapr/state_api:replace cel-go with v0.5.1

6c227a0

Signed-off-by: zach <zachchou016@gmail.com>

dapr/state_api:fix state api ut

a085a3a

Signed-off-by: zach <zachchou016@gmail.com>

seeflood assigned wenxuwan Jan 5, 2022

MoonShining reviewed Jan 7, 2022

View reviewed changes

pkg/grpc/default_api/api_state.go Outdated Show resolved Hide resolved

zach030 and others added 2 commits January 7, 2022 23:45

dapr/state_api:init slice with cap

fa3ecdd

Signed-off-by: zach <zachchou016@gmail.com>

Merge branch 'main' into feature_dapr_state_api

bae2a80

wenxuwan previously approved these changes Jan 10, 2022

View reviewed changes

seeflood requested changes Jan 11, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Merge branch 'main' into feature_dapr_state_api

9232603

seeflood requested changes Jan 11, 2022

View reviewed changes

pkg/grpc/dapr/dapr_api_state.go Outdated Show resolved Hide resolved

zach030 added 2 commits January 11, 2022 18:49

dapr/state_api: remove encrypt dependency

319e9f3

Signed-off-by: zach <zachchou016@gmail.com>

Merge branch 'feature_dapr_state_api' of github.com:zach030/layotto i…

5dc188d

…nto feature_dapr_state_api Signed-off-by: zach <zachchou016@gmail.com>

zach030 dismissed wenxuwan’s stale review via 5dc188d January 11, 2022 10:58

mosn-community-bot bot added size/XL and removed size/XXL labels Jan 11, 2022

remove unused code

3d5df19

mosn-community-bot bot added size/XXL and removed size/XL labels Jan 13, 2022

add comments

d1f3b25

seeflood approved these changes Jan 13, 2022

View reviewed changes

wenxuwan approved these changes Jan 13, 2022

View reviewed changes

wenxuwan merged commit d75608f into mosn:main Jan 13, 2022

seeflood mentioned this pull request Mar 4, 2022

Add support for Dapr API #361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support dapr state api #377

feature: support dapr state api #377

zach030 commented Dec 28, 2021

seeflood commented Dec 29, 2021

wenxuwan commented Dec 29, 2021

wenxuwan commented Dec 29, 2021

zach030 commented Dec 29, 2021

wenxuwan commented Dec 30, 2021

zach030 commented Dec 30, 2021

wenxuwan commented Dec 31, 2021

codecov bot commented Jan 1, 2022 •

edited

Loading

zach030 commented Jan 4, 2022

wenxuwan commented Jan 4, 2022

wenxuwan left a comment

zach030 commented Jan 11, 2022

seeflood commented Jan 13, 2022

seeflood left a comment

wenxuwan left a comment

feature: support dapr state api #377

feature: support dapr state api #377

Conversation

zach030 commented Dec 28, 2021

seeflood commented Dec 29, 2021

wenxuwan commented Dec 29, 2021

wenxuwan commented Dec 29, 2021

zach030 commented Dec 29, 2021

wenxuwan commented Dec 30, 2021

zach030 commented Dec 30, 2021

wenxuwan commented Dec 31, 2021

codecov bot commented Jan 1, 2022 • edited Loading

Codecov Report

zach030 commented Jan 4, 2022

wenxuwan commented Jan 4, 2022

wenxuwan left a comment

Choose a reason for hiding this comment

zach030 commented Jan 11, 2022

seeflood commented Jan 13, 2022

seeflood left a comment

Choose a reason for hiding this comment

wenxuwan left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 1, 2022 •

edited

Loading