Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove VERSION for new pipelines #517

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Apr 30, 2022

Signed-off-by: Xunzhuo mixdeers@gmail.com

resolve: #521

remove VERSION for new pipelines, we use git describe to get latest git tag, we do not need it anymore.

Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #517 (71d46f5) into main (26ae3ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 71d46f5 differs from pull request most recent head bc8d0e3. Consider uploading reports for the commit bc8d0e3 to get more accurate results

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3868     3868           
  Misses       2144     2144           
  Partials      370      370           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223945e...bc8d0e3. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented May 1, 2022

I just found a problem with version.
Layotto used compilation flags to modify the Version variable in main.go and :
image
But we removed the flags in new CI , which leads to some issues.
For example, if you run the layotto binary, there's no version information in the printed message:
image

Besides, the actuator API can't get the right version.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented May 1, 2022

Easy fix, I will start a PR to fix it later:)

@seeflood
Copy link
Member

seeflood commented May 1, 2022

Ok. Let's record it in a new issue and merge this PR

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xunzhuo
Copy link
Member Author

Xunzhuo commented May 1, 2022

#516 Can we merge this PR first, this is related to publish amd64 image.

@Xunzhuo Xunzhuo mentioned this pull request May 3, 2022
25 tasks
@JervyShi JervyShi self-requested a review May 3, 2022 12:40
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 842bedb into mosn:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no compilation flags for version
3 participants