Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jaeger #590

Merged
merged 37 commits into from
Jun 7, 2022
Merged

feat: add jaeger #590

merged 37 commits into from
Jun 7, 2022

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented May 20, 2022 •
edited
Loading

What this PR does:

layotto add jaeger

Which issue(s) this PR fixes:
#547

@LXPWing LXPWing changed the title Feature/add jaeger feat: add jaeger May 20, 2022
@LXPWing
Copy link
Member Author

LXPWing commented May 24, 2022

I don't know how to fix this error
image

seeflood
seeflood reviewed May 26, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #590 (465eeaa) into main (d991eba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea7d5d...465eeaa. Read the comment docs.

seeflood
seeflood requested changes May 28, 2022
View reviewed changes
docs/zh/start/trace/jaeger.md Outdated Show resolved Hide resolved
seeflood
seeflood requested changes Jun 3, 2022
View reviewed changes
docs/zh/start/trace/jaeger.md Outdated Show resolved Hide resolved
@seeflood seeflood self-assigned this Jun 4, 2022
seeflood
seeflood approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks !!

@seeflood seeflood merged commit 36ed813 into mosn:main Jun 7, 2022
@seeflood seeflood linked an issue Jun 8, 2022 that may be closed by this pull request
feature: layotto integration jaeger #547
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeflood seeflood seeflood approved these changes

@zhenjunMa zhenjunMa zhenjunMa approved these changes

Assignees

@seeflood seeflood

Labels
area/community cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: layotto integration jaeger
3 participants
@LXPWing @seeflood @zhenjunMa