Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secret ref key #724

Merged
merged 13 commits into from
Jul 21, 2022
Merged

fix: add secret ref key #724

merged 13 commits into from
Jul 21, 2022

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented Jul 16, 2022

What this PR does:
add secret ref key
Which issue(s) this PR fixes:

Fixes #707

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels Jul 16, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #724 (673ee45) into main (855e9c2) will increase coverage by 0.05%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   60.06%   60.12%   +0.05%     
==========================================
  Files         128      128              
  Lines        6769     6774       +5     
==========================================
+ Hits         4066     4073       +7     
+ Misses       2311     2310       -1     
+ Partials      392      391       -1     
Impacted Files Coverage Δ
pkg/runtime/ref/injector.go 82.60% <71.42%> (+15.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855e9c2...673ee45. Read the comment docs.

components/ref/config.go Outdated Show resolved Hide resolved
components/ref/config.go Outdated Show resolved Hide resolved
components/ref/config.go Outdated Show resolved Hide resolved
docs/en/start/secret/secret_ref.md Outdated Show resolved Hide resolved
docs/en/start/secret/secret_ref.md Outdated Show resolved Hide resolved
docs/zh/start/secret/secret_ref.md Outdated Show resolved Hide resolved
docs/zh/start/secret/secret_ref.md Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit e0fa928 into mosn:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret ref not flexible enough
3 participants