Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit test failed info more clear in ci #955

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

alilestera
Copy link
Contributor

What this PR does:
make unit test failed info more clear in ci
Which issue(s) this PR fixes:

Fixes #646

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@github-actions
Copy link

Hi @alilestera. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@layotto-cla
Copy link

layotto-cla bot commented Jun 27, 2023

Hi @alilestera, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8f2c52f) 59.80% compared to head (deb9431) 59.80%.

❗ Current head deb9431 differs from pull request most recent head f586b59. Consider uploading reports for the commit f586b59 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   59.80%   59.80%           
=======================================
  Files         138      138           
  Lines        9546     9546           
=======================================
  Hits         5709     5709           
  Misses       3116     3116           
  Partials      721      721           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wenxuwan wenxuwan requested review from Xunzhuo and zhenjunMa June 29, 2023 03:11
@Xunzhuo
Copy link
Member

Xunzhuo commented Jun 29, 2023

/lgtm
/approve

Thanks!

@github-actions
Copy link

[LGTMNOTIFIER] This PR is LGTM

This pull-request has been lgtm by: @Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs reviewers from an reviewer in each of these files:

Reviewers can indicate their approval by writing /lgtm in a comment
Reviewers can cancel approval by writing /lgtm cancel in a comment

@github-actions github-actions bot added the lgtm label Jun 29, 2023
@github-actions
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: @Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot merged commit 65ea297 into mosn:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

让 CI 中的报错信息更直观
2 participants