provides for multiple executors operating under a single runner #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
force-pushed
the
runner-interface
branch
3 times, most recently
from
b9d939b to
8d612cc
Compare
robacarp
force-pushed
the
runner-interface
branch
6 times, most recently
from
b539365 to
478221a
Compare
robacarp
force-pushed
the
runner-interface
branch
4 times, most recently
from
b6423ec to
6245c0a
Compare
robacarp
force-pushed
the
runner-interface
branch
3 times, most recently
from
d5580eb to
559588d
Compare
There was a problem hiding this comment.
Well, everything looks really nice :)
I'm not as familiar with the inner workings as I should be to leave any meaningful comments/feedback, but one thing that sticks out is the lack of documentation comments and using return types.
Even if you only add comments to generate public docs, I'd highly recommend doing that while everything is fresh in your mind and :nodoc: everything you want to be in the private API
robacarp
force-pushed
the
runner-interface
branch
from
559588d to
f2207fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #122 #18 and #80
My goal here is to minimally make mosquito network bound workloads significantly faster. Testing with @mamantoha shards.info codebase it’s trivial to cut the scrape time for the whole run by 60-70% because the whole workload is network bound. CPU abound workloads will have almost no benefit here, but the framework is laid for multi process work in the future.
As always, comments welcome and appreciated.