Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of the LineReader by reducing the number of system calls whilst containing the tail size #93

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Improve the performance of the LineReader by reducing the number of system calls whilst containing the tail size #93

merged 5 commits into from
Oct 8, 2024
+15 −14

Conversation

HaukurPall
Copy link
Contributor

Fixes #92 and #80 (I think)

@HaukurPall
Copy link
Contributor Author

HaukurPall commented Jun 28, 2024 •
edited
Loading

The TextFileWrapper and BinaryFileWrapper readline() use a similar pattern as described in #92 but since the buffer does not persist between calls a fix does not make sense. Thankfully, for those classes, when iterating over lines (__aiter__) the improved LineReader is used.

This was referenced Jun 28, 2024
Open
Closed
@mosquito mosquito merged commit a155a74 into mosquito:master Oct 8, 2024
@gnzsnz
Copy link

gnzsnz commented Oct 8, 2024

great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosquito mosquito mosquito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance issue and suggested fix
3 participants
@HaukurPall @gnzsnz @mosquito