fix: prevent segfault on unicode surrogate characters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing strings containing surrogate characters (e.g. \udfff) to the journal,
the program would segfault instead of raising an exception. This occurred because
_send() attempted to free uninitialized memory when encode() raised UnicodeEncodeError.
Changes:
- Use PyMem_Calloc instead of PyMem_Malloc for cstring_list to ensure zero-initialized memory
- Add NULL check before PyMem_Free to safely handle partially allocated memory
- Add missing imports in async_reader.py
Example of previously failing code that now works safely:
```python
from cysystemd.journal import write
write("Hello, \udfff world!") # Now raises ValueError instead of segfault
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing strings containing surrogate characters (e.g. \udfff) to the journal, the program would segfault instead of raising an exception. This occurred because _send() attempted to free uninitialized memory when encode() raised UnicodeEncodeError.
Changes:
Example of previously failing code that now works safely:
fixes #67