Tried pip installing the package, fails for f-strings

[jowa-ea]

Hey,

I renctly tried to !pip install the package, which fails because of some f-strings not being set up properly.
Example in core/scale_bar.py on line 752:

warnings.warn(f"Provided bar length ({bar["length"]}) is greater than the axis length ({ax_dim}); setting bar length to default (25% of axis length).")
should probably be
warnings.warn(f"Provided bar length ({bar['length']}) is greater than the axis length ({ax_dim}); setting bar length to default (25% of axis length).")

Cheers,
jowa_ea

[moss-xyz]

Hello - can you clarify if you're having trouble installing via pip, or using the package itself?

I just re-installed the package myself to check it was working, and didn't run into any problems.

For what you provided, I'm not sure that should be an issue - I believe since bar["length"] is captured in curly braces, I should be able to use double quotes to designate the key value without interfering with the rest of the quote string, even if it also uses double quotes, like in the example below:

test = {"key":"val"}
print(f"The output is {test["key"]}") # will print 'The output is val'

If you're getting a specific error when using, do you mind sharing the code + your setup (mainly the versions of the dependent packages and Python you are using)?

[jairomr]

Unfortunately, this syntax only works in Python 3.12 or higher. In older versions, the code below will generate a syntax error:

test = {"key": "val"}
print(f"The output is {test["key"]}")  # Error in versions < 3.12

[moss-xyz]

Ah that is a fascinating issue I wasn't aware of, but you are right.

I see your request to update the minimum python version to 3.12, which would certainly solve the issue, but I wonder if it would be better to instead fix the inside-outside quote problem instead, so that this can be used down to 3.9.

I wouldn't go through this effort if there are other changes that would have to be made though - are you aware of any @jairomr?

[moss-xyz]

Okay there were fewer of those f-strings than I thought, so my regex was able to capture them all and make the updates.

Unfortunately, this package is still incompatible with python 3.9 because it uses type concatenation in functions (ex. units: None | bool | sbt._TYPE_UNITS=None). However, it does work with 3.10 now that I have fixed the f-string issue, so I have incremented the minimum python version required.

A new version is available via pip, so I am closing this issue for now; @jowa-ea, reopen if you are still have difficulties with this specific topic (make a new issue if it is about another topic).

@jairomr thank you for your help! I won't be accepting the pr though, as it conflicts with the changes I just made.

[jowa-ea]

Great! Thank you very much :)