-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to consume from all partitions #12
Comments
Hey @fmck3516, TLDR; Long story short, I am more than happy to refactor this code and make it look more like Go code with Go best practices, meaning: I am happy to see PRs on this. |
Thanks for the context. I will raise a PR. Even though xk6-kafka is not ready for prime time yet: I'm pretty confident that we can turn this into something that provides a lot of value for a lot of people if we push it beyond the POC state. |
Update example scripts Fix linting errors
@fmck3516 |
Thanks - I will do a review later today. |
@fmck3516 Any luck with testing this? |
WOW! Nice! 👏 |
Update example scripts Fix linting errors
Hi - are there plans to add support to consume from all partitions? I took a quick glance at
consumer.go
and it looks like the current implementation only allows to consume from one partition.The text was updated successfully, but these errors were encountered: