build: migrate to typescript #296

raveclassic · 2019-08-08T17:37:15Z

Hi, guys!

So following mostjs/hold#36 this PR moves all the source entirely to typescript. There're a lot of changes and I thought although it would be hard to review everything in one time it would be even harder to migrate separately.

Some notes about the changes:

I tried to be as less invasive with the code as possible, only types were added. however there were some places (internally and mostly in tests) which relied for example on passing value to Sink#end method and so on - so I removed them
babel and its configuration was removed
mocha/nyc were updated to support typescript
resulting .d.ts files may be different from original most.d.ts although I tried my best to replicate everything. However I may have missed something.
I didn't touch perf tests as they seem a bit awkward to me because they contain dependencies on the packages which are not in package.json. If it's important I'll try once again to migrate them as well.

I don't expect this to be merged smooth but I'm looking forward to finding out all the problems and fixing them. I do love most and I would love to move this awesome library to the best static-typing solution.

briancavalier · 2019-08-10T00:41:29Z

@raveclassic Thank you for this incredible undertaking! The core team discussed briefly today, and we are all supportive of the move to TS.

I should have time to start looking at this over the weekend.

Frikki

A bit of a review.

.vscode/settings.json

packages/core/src/Queue.ts

packages/core/src/combinator/combine.ts

briancavalier

Sorry it's taken me longer to get started reviewing this than I thought. Thank you again for this work! I left a couple higher level items for discussion. I'll try to make incremental progress in reviewing over the next couple days.

packages/core/src/combinator/combine.ts

packages/core/src/combinator/continueWith.ts

briancavalier

Great progress. Let's keep this going! A few more comments as I work my may through.

packages/core/src/combinator/combine.ts

packages/core/src/combinator/errors.ts

packages/core/src/combinator/limit.ts

packages/core/src/combinator/merge.ts

Frikki

Some more reviewed files.

packages/core/src/combinator/delay.ts

packages/core/src/combinator/filter.ts

packages/core/src/combinator/limit.ts

packages/core/src/combinator/timeslice.ts

packages/core/src/combinator/transform.ts

Frikki

25% reviewed. Phew!!!

packages/core/src/combinator/switch.ts

packages/core/src/combinator/zip.ts

packages/core/src/invoke.ts

briancavalier

Slowly but surely, I'm working my way through. Thanks being patient and continuing to work through this.

packages/core/src/fusion/Map.ts

packages/core/src/sink/IndexSink.ts

Frikki

PropagateTask.ts reviewed.

packages/core/src/scheduler/PropagateTask.ts

briancavalier

Whew! I think I made it all the way to the end 😄 Thanks for continuing to move this forward! A few more questions and comments.

packages/disposable/src/disposeAll.ts

packages/disposable/test/disposeAll-test.ts

packages/prelude/src/array.ts

packages/prelude/test/array-test.ts

packages/scheduler/src/ScheduledTask.ts

packages/scheduler/src/Scheduler.ts

packages/scheduler/src/Timeline.ts

packages/scheduler/src/ClockTimer.ts

briancavalier

This is looking great overall. A couple more very minor comments.

packages/prelude/test/array-test.ts

packages/prelude/src/array.ts

briancavalier · 2019-10-02T12:43:16Z

Hey @raveclassic, I haven’t forgotten about this. I’m on vacation with little to no internet access until 7 Oct. I’ll get back to this ASAP once I’ve returned.

Frikki · 2019-10-02T19:39:16Z

Yea, @raveclassic, I haven’t forgotten either. Just very busy with an upcoming release at my day job, which have been stealing my energy for extra code and open source projects. I will also be back on track next week. Thanks for your patience.

raveclassic · 2019-10-03T10:55:18Z

No problem, guys, I'm also on vacation right now until next week :)

Frikki · 2019-10-09T19:45:12Z

I am delayed.

raveclassic · 2019-10-24T11:55:26Z

Guys? :)

briancavalier

@raveclassic @Frikki I finally got back to this 😬

packages/prelude/src/array.ts

# Conflicts: # package-lock.json

briancavalier · 2019-11-12T02:24:01Z

Now that the most/prelude readonly array issue seems to be resolved, I've lost track of how close we are to the finish line overall.

@raveclassic Are there things you know are still left to do? If so, could you edit the PR description and list them (with checkboxes!). If not, then maybe we just need a final review and for at least one of the core team to pull a clean copy and ensure everything compiles and type checks.

Other thoughts on how to proceed?

raveclassic · 2019-11-12T08:58:45Z

@briancavalier It seems like everything you and @Frikki mentioned is resolved. Do you remember what files/packages you haven't seen yet?

briancavalier · 2019-11-12T11:12:49Z

@raveclassic Thanks. I think I've been through all the files at one time or another. I feel like I need to do 2 things:

Pull a fresh copy of the latest, and run the build and test.
Go through all the files quickly again for one last sanity check.

I'll start on those now.

briancavalier · 2019-11-12T11:34:43Z

Pull a fresh copy of the latest, and run the build and test.

I just did this and everything worked perfectly, except for the perf tests. Running the various test files directly with node works (since you added ts-node/register 👍), but the npm scripts (e.g., npm run chain) don't as they still reference babel-node.

I think it's an easy fix: We can update the package.json scripts from, e.g., babel-node --presets env ./chain.js to node ./chain.js.

Now I'm on to a final skim review of all the files.

briancavalier · 2019-11-13T16:52:45Z

packages/core/src/combinator/merge.ts

      return
    }
    this.sink.event(t, indexValue.value)
  }

-  _dispose (t, index) {
+  private dispose(t: Time, index: number): void {


Thank you for making all the "private by convention" methods actually private .

briancavalier

I made it through a quick scan of all the files again 😌. Looks good to merge!

Thank you for this monumental effort and your patience while we all worked through it together, @raveclassic. Great work.

Frikki

I think that now that tests are passing, we should get this PR into production.

raveclassic · 2020-09-25T12:45:19Z

@briancavalier Turns out this has never been released :D Could you publish the new version?

briancavalier · 2020-09-30T02:01:18Z

Hey @raveclassic. Whoops! Thanks for the nudge. Just published updated versions of everything:

Successfully published:
 - @most/core@1.6.0
 - @most/disposable@1.3.0
 - @most/prelude@1.8.0
 - @most/scheduler@1.3.0
 - @most/types@1.1.0
lerna success published 5 packages

nissoh · 2020-10-01T09:35:58Z

Hey @raveclassic. Whoops! Thanks for the nudge. Just published updated versions of everything:
Successfully published:
 - @most/core@1.6.0
 - @most/disposable@1.3.0
 - @most/prelude@1.8.0
 - @most/scheduler@1.3.0
 - @most/types@1.1.0
lerna success published 5 packages

@briancavalier i get a Typescript transpiling error because of a wrong reference to the entry TS file within package.json

check PR #525

raveclassic added 7 commits August 5, 2019 17:26

build(prelude): migrate to typescript

d521db8

build(disposable): migrate to typescript

4e86056

git

5665024

build(core): migrate to typescript

c461f3c

build(core): migrate to typescript // fix build

34c68f8

build(core): migrate to typescript // fix build

8b07756

build(core): migrate to typescript // fix eslint

017855d

Frikki requested changes Aug 12, 2019

View reviewed changes

raveclassic added 2 commits August 13, 2019 14:35

postreview

b34be98

postreview

f16295b

briancavalier reviewed Aug 14, 2019

View reviewed changes

packages/core/src/combinator/combine.ts Outdated Show resolved Hide resolved

packages/core/src/combinator/combine.ts Outdated Show resolved Hide resolved

packages/core/src/combinator/combine.ts Outdated Show resolved Hide resolved

raveclassic and others added 3 commits August 14, 2019 11:38

remove vscode settings

334d68c

replace standard with eslint

b8357ec

update combine to ToStreamsArray

03440dc

Frikki requested changes Aug 14, 2019

View reviewed changes

briancavalier reviewed Aug 15, 2019

View reviewed changes

Frikki requested changes Aug 17, 2019

View reviewed changes

raveclassic added 5 commits August 19, 2019 12:02

postreview

1701b85

postreview

6b27f04

postreview

40695e3

postreview

70a8b56

fix curry3 typings

61e5c54

raveclassic mentioned this pull request Aug 19, 2019

TypeScript & Flow Definitions incomplete for partial application #290

Open

Frikki requested changes Aug 20, 2019

View reviewed changes

packages/core/src/combinator/switch.ts Show resolved Hide resolved

packages/core/src/combinator/zip.ts Outdated Show resolved Hide resolved

packages/core/src/invoke.ts Outdated Show resolved Hide resolved

briancavalier reviewed Aug 21, 2019

View reviewed changes

packages/core/src/fusion/Map.ts Outdated Show resolved Hide resolved

packages/core/src/sink/IndexSink.ts Outdated Show resolved Hide resolved

raveclassic added 3 commits August 21, 2019 12:23

replace any with unknown

1b24b9c

replace bangs with casts and add todo comments

7e516b1

replace any with unknown

7900b66

Frikki requested changes Aug 22, 2019

View reviewed changes

packages/core/src/scheduler/PropagateTask.ts Outdated Show resolved Hide resolved

packages/core/src/scheduler/PropagateTask.ts Outdated Show resolved Hide resolved

packages/core/src/scheduler/PropagateTask.ts Outdated Show resolved Hide resolved

briancavalier reviewed Sep 11, 2019

View reviewed changes

raveclassic added 2 commits September 17, 2019 14:26

style: postreview

8ef111a

style: remove extra space

253909b

raveclassic requested a review from briancavalier September 17, 2019 13:28

feat: arrayLike

6429390

raveclassic mentioned this pull request Sep 18, 2019

Suggestion: use ArrayLike for TypeScript Definitions #156

Closed

briancavalier reviewed Sep 19, 2019

View reviewed changes

packages/prelude/test/array-test.ts Show resolved Hide resolved

packages/prelude/src/array.ts Show resolved Hide resolved

test: associativity for concat

5d638a3

raveclassic requested a review from briancavalier September 26, 2019 10:11

raveclassic mentioned this pull request Oct 27, 2019

Explain why Readonly array is not good idea gcanti/fp-ts#987

Closed

briancavalier reviewed Nov 5, 2019

View reviewed changes

packages/prelude/src/array.ts Show resolved Hide resolved

raveclassic force-pushed the typescript branch from a223543 to 5d638a3 Compare November 5, 2019 14:51

Merge branch 'master' into typescript

5a3b2e3

# Conflicts: # package-lock.json

briancavalier reviewed Nov 13, 2019

View reviewed changes

briancavalier approved these changes Nov 20, 2019

View reviewed changes

Frikki approved these changes Nov 20, 2019

View reviewed changes

briancavalier merged commit e37adda into mostjs:master Nov 20, 2019

briancavalier mentioned this pull request Nov 20, 2019

ADR: Add static types #219

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: migrate to typescript #296

build: migrate to typescript #296

raveclassic commented Aug 8, 2019 •

edited

Loading

briancavalier commented Aug 10, 2019

Frikki left a comment

briancavalier left a comment

briancavalier left a comment

Frikki left a comment

Frikki left a comment

briancavalier left a comment

Frikki left a comment

briancavalier left a comment

briancavalier left a comment

briancavalier commented Oct 2, 2019

Frikki commented Oct 2, 2019

raveclassic commented Oct 3, 2019

Frikki commented Oct 9, 2019

raveclassic commented Oct 24, 2019

briancavalier left a comment

briancavalier commented Nov 12, 2019

raveclassic commented Nov 12, 2019

briancavalier commented Nov 12, 2019 •

edited

Loading

briancavalier commented Nov 12, 2019

briancavalier Nov 13, 2019

briancavalier left a comment

Frikki left a comment

raveclassic commented Sep 25, 2020

briancavalier commented Sep 30, 2020 •

edited

Loading

nissoh commented Oct 1, 2020

build: migrate to typescript #296

build: migrate to typescript #296

Conversation

raveclassic commented Aug 8, 2019 • edited Loading

briancavalier commented Aug 10, 2019

Frikki left a comment

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

Frikki left a comment

Choose a reason for hiding this comment

Frikki left a comment

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

Frikki left a comment

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

briancavalier commented Oct 2, 2019

Frikki commented Oct 2, 2019

raveclassic commented Oct 3, 2019

Frikki commented Oct 9, 2019

raveclassic commented Oct 24, 2019

briancavalier left a comment

Choose a reason for hiding this comment

briancavalier commented Nov 12, 2019

raveclassic commented Nov 12, 2019

briancavalier commented Nov 12, 2019 • edited Loading

briancavalier commented Nov 12, 2019

briancavalier Nov 13, 2019

Choose a reason for hiding this comment

briancavalier left a comment

Choose a reason for hiding this comment

Frikki left a comment

Choose a reason for hiding this comment

raveclassic commented Sep 25, 2020

briancavalier commented Sep 30, 2020 • edited Loading

nissoh commented Oct 1, 2020

raveclassic commented Aug 8, 2019 •

edited

Loading

briancavalier commented Nov 12, 2019 •

edited

Loading

briancavalier commented Sep 30, 2020 •

edited

Loading