Fix#175: 토스페이먼츠 심사를 위한 Initiializer 에 개인정보 제거#176
Conversation
WalkthroughThe phone number string literals in two user creation methods within the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a compliance requirement by anonymizing personal information within the application's database initializer. The primary goal is to remove specific phone numbers from dummy user data, which is essential for the Toss Payments review process. This ensures that the application's initialization process uses generic, non-sensitive data.
Highlights
- Data Anonymization: The pull request updates the
DatabaseInitializerto replace a specific hardcoded phone number (010-5048-6201) with a generic placeholder (010-1234-5678). This change is applied in both thecreateUsersAndProfilesandcreateAdditionalUsersmethods, ensuring that dummy user data generated for testing or review purposes does not contain identifiable personal information. - Code Formatting/Imports: Import statements within
src/main/java/life/mosu/mosuserver/global/initializer/DatabaseInitializer.javahave been reordered. Specifically,jakarta.annotation.PostConstruct,org.springframework.security.crypto.password.PasswordEncoder, andorg.springframework.stereotype.Componentimports were moved to new positions, which is a stylistic change for better code organization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses issue #175 by removing personal information (a phone number) from the DatabaseInitializer. This is an important security improvement to avoid committing sensitive data to the repository. The change is correct and achieves its goal. My only suggestion is to extract the new dummy phone number into a constant to improve code maintainability and avoid duplicated magic strings, following standard Java best practices.
| .gender(i % 2 == 0 ? Gender.MALE : Gender.FEMALE) | ||
| .name("모수학생" + i) | ||
| .phoneNumber("010-5048-6201") | ||
| .phoneNumber("010-1234-5678") |
There was a problem hiding this comment.
Thank you for removing the hardcoded personal information. This is an important security improvement.
The new dummy phone number "010-1234-5678" is now a 'magic string'. According to Java best practices, it's better to avoid magic strings, especially when they are duplicated (as seen here and on line 148).
To improve maintainability, I recommend defining this value as a private static final constant at the class level. This ensures consistency and makes future changes easier.
Example:
You could add this field to your class:
private static final String DUMMY_PHONE_NUMBER = "010-1234-5678";And then use the constant DUMMY_PHONE_NUMBER in both places.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/life/mosu/mosuserver/global/initializer/DatabaseInitializer.java (1)
111-112: Placeholder phone numbers are still hard-coded & duplicated—centralise and scrub remaining occurrencesGood step replacing the real-looking number, but:
- The same literal
"010-1234-5678"now appears in multiple places, which is easy to miss in future clean-ups.- There are still other phone literals in this file (e.g.
"010-9876-5432"and the generated parent numbers) that may also need anonymising to fully satisfy the “remove personal information” requirement.Recommend defining a single constant (or external config) and referencing it everywhere. That both documents intent and prevents accidental real data leakage.
@@ - .phoneNumber("010-1234-5678") + .phoneNumber(PLACEHOLDER_PHONE) @@ - .phoneNumber("010-1234-5678") + .phoneNumber(PLACEHOLDER_PHONE) + +// near the top of the class +private static final String PLACEHOLDER_PHONE = "010-1234-5678";After refactor, grep the codebase for
010-and verify no stray personal numbers remain.Also applies to: 148-149
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/life/mosu/mosuserver/global/initializer/DatabaseInitializer.java(3 hunks)
2 participants
✨ 구현한 기능
Summary by CodeRabbit
Style
Chores