-
Notifications
You must be signed in to change notification settings - Fork 2
[배포] 내 문의 내역 조회 시 답변도 같이 반환 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
22a2b70
MOSU refactor: set secure flag to false for development cookies
wlgns12370 a01febf
feat: enhance inquiry search functionality with answer details and ne…
jbh010204 da43546
feat: 내 문의 내역 조회 시 답변도 같이 반환
jbh010204 1e4f080
refactor: 리뷰 내용 반영
jbh010204 8af2cdb
Merge pull request #290 from mosu-dev/refactor/mosu-287
jbh010204 f8e1232
refactor: set secure flag to true for development cookies
wlgns12370 76d795e
Merge remote-tracking branch 'origin/develop' into develop
wlgns12370 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/main/java/life/mosu/mosuserver/presentation/inquiry/dto/InquiryAnswerResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package life.mosu.mosuserver.presentation.inquiry.dto; | ||
|
|
||
| public record InquiryAnswerResponse( | ||
| String title, | ||
| String content, | ||
| String author, | ||
| String createdAt, | ||
| String updatedAt | ||
| ) { | ||
|
|
||
| } |
14 changes: 14 additions & 0 deletions
14
src/main/java/life/mosu/mosuserver/presentation/inquiry/dto/InquiryListResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package life.mosu.mosuserver.presentation.inquiry.dto; | ||
|
|
||
| public record InquiryListResponse( | ||
| InquiryResponse inquiry, | ||
| InquiryAnswerResponse reply | ||
| ) { | ||
|
|
||
| public static InquiryListResponse of( | ||
| InquiryResponse inquiry, | ||
| InquiryAnswerResponse reply | ||
| ) { | ||
| return new InquiryListResponse(inquiry, reply); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sorting is hardcoded to be descending by
createdAt. ThePageableobject, which is passed as an argument to this method, can contain sorting information from the client request, but it is being ignored. This prevents clients from sorting the inquiry list according to their needs. It is recommended to use theSortinformation from thePageableobject to apply dynamic sorting. You could adapt the existingbuildOrderByConditionmethod or create a new helper to handle this.