-
Notifications
You must be signed in to change notification settings - Fork 2
MOSU-39 feat: 신청 관련 기능 수정 및 관리자 신청 조회 관련 기능 구현 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
effbf11
MOSU-39 feat: 관리자 신청 내역 조회관련, 학교별 도시락 수 조회 controller 구현
chominju02 0310b87
MOSU-39 feat: 관리자 신청 내역 조회관련, 학교별 도시락 수 조회 service 구현
chominju02 745be06
MOSU-39 feat: 관리자 신청 내역 조회관련, 학교별 도시락 수 조회 repository 구현
chominju02 a2ef70e
MOSU-39 feat: ApplicationListResponse 구현
chominju02 4bba82d
MOSU-39 feat: ApplicationExcelDto 구현
chominju02 1fcacd4
MOSU-39 feat: ApplicationFilter 구현
chominju02 51e82d6
MOSU-39 feat: Application guardianPhoneNumber 추가
chominju02 19fb1ce
MOSU-39 chore: ApplicationRequest address 제거 및 school의 address 추가
chominju02 4d8d36c
MOSU-39 chore: enum 값 추가
chominju02 a52124f
MOSU-39 chore: ObjectMapper 수정
chominju02 2a54e0b
MOSU-39 chore: PhoneNumberPattern 수정 및 적용
chominju02 27de617
MOSU-39 chore: response subject -> string 타입 변경 및 변경 로직 추가
chominju02 a21f3b0
MOSU-39 chore: @UserId 적용
chominju02 3794e2b
MOSU-39 chore: 설정 파일 변경
chominju02 9463508
MOSU-39 feat: SchoolJpaRepository 구현
chominju02 b6a25ad
MOSU-39 feat: SchoolLunchResponse 구현
chominju02 11ff2d1
MOSU-39 chore: userRole length 변경
chominju02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,4 +36,5 @@ out/ | |
| ### VS Code ### | ||
| .vscode/ | ||
|
|
||
| docker-compose/.env | ||
| docker-compose/.env | ||
| docker-compose/.env.local | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/main/java/life/mosu/mosuserver/domain/admin/ApplicationQueryRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package life.mosu.mosuserver.domain.admin; | ||
|
|
||
| import java.util.List; | ||
| import life.mosu.mosuserver.presentation.admin.dto.ApplicationExcelDto; | ||
| import life.mosu.mosuserver.presentation.admin.dto.ApplicationFilter; | ||
| import life.mosu.mosuserver.presentation.admin.dto.ApplicationListResponse; | ||
| import life.mosu.mosuserver.presentation.admin.dto.SchoolLunchResponse; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.Pageable; | ||
|
|
||
| public interface ApplicationQueryRepository { | ||
|
|
||
| Page<ApplicationListResponse> searchAllApplications(ApplicationFilter filter, | ||
| Pageable pageable); | ||
|
|
||
| List<ApplicationExcelDto> searchAllApplicationsForExcel(); | ||
|
|
||
| List<SchoolLunchResponse> searchAllSchoolLunches(); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Architecture concern: Domain layer importing presentation DTOs.
The domain layer is importing DTOs from the presentation layer (lines 4-7), which violates the typical layered architecture where domain should not depend on presentation. This creates a reverse dependency that makes the domain layer less reusable and harder to test.
Consider moving these DTOs to a shared package or creating separate domain-specific DTOs:
📝 Committable suggestion
🤖 Prompt for AI Agents