don't override falsy values in process.env #17
Conversation
|
Based on some quick testing with another project this seems to resolve #18 |
|
@motdotla Any chance of this getting merged in? Is there anything else you'd want to see in a PR like this to get it across the finish line or is there a different way you'd see the fix being implemented? |
| @@ -8,7 +8,7 @@ var dotenvExpand = function (config) { | |||
| var key = match.replace(/\$|{|}/g, '') | |||
|
|
|||
| // process.env value 'wins' over .env file's value | |||
| var variable = process.env[key] || config.parsed[key] || '' | |||
| var variable = process.env.hasOwnProperty(key) ? process.env[key] : (config.parsed[key] || '') | |||
There was a problem hiding this comment.
Should the two lines you updated be abstracted into a method given the similarities between the two?
There was a problem hiding this comment.
sorry, this is not code refactoring PR. it just fixing an issue.
you can make you own fork and make some additional changes, but it looks like there no chance to merge it.
|
This looks good. Thank you guys, good catch. Merging. |
|
This is available in 5.0.0 now https://www.npmjs.com/package/dotenv-expand |
No description provided.