Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: upload to s3 and deploy from bucket #444

Closed
teebu opened this issue Jul 23, 2018 · 4 comments · Fixed by #446
Closed

Feature request: upload to s3 and deploy from bucket #444

teebu opened this issue Jul 23, 2018 · 4 comments · Fixed by #446

Comments

@teebu
Copy link

teebu commented Jul 23, 2018

Same thing to what it's doing now, but instead of sending the zip directly to AWS lambda, it first uploads it to a predefined bucket/key(prefix) and deploys from s3.

Advantage: size limits seem to be much higher when deploying from s3, 250meg zips, vs direct zip upload which is limited to 50megs.

@abetomo
Copy link
Contributor

abetomo commented Jul 24, 2018

I think that it is useful to upload it to S3 and deploy it.
However, I think that the upper limit of the zip file size does not change even if uploading to S3.
250 MB seems to be the size of the code before compression.

https://docs.aws.amazon.com/lambda/latest/dg/limits.html
[AWS Lambda Deployment Limits]

@teebu
Copy link
Author

teebu commented Jul 24, 2018

https://hackernoon.com/exploring-the-aws-lambda-deployment-limits-9a8384b0bec3

It's been tested, and I can confirm.

@abetomo
Copy link
Contributor

abetomo commented Jul 24, 2018

Thanks for sharing information.

@abetomo
Copy link
Contributor

abetomo commented Jul 24, 2018

Add the function to deploy from S3.
Please wait for a few days before opening the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants