Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature upload to s3 and deploy from bucket #446

Merged
merged 8 commits into from
Jul 24, 2018
Merged

Feature upload to s3 and deploy from bucket #446

merged 8 commits into from
Jul 24, 2018

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Jul 24, 2018

fixes #444

DeviaVir
DeviaVir approved these changes Jul 24, 2018
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, did you test it out already?

@abetomo
Copy link
Contributor Author

abetomo commented Jul 24, 2018

Thank you for review.
It is already tested when creating a new one.
In the case of update, it is not tested, and it checked and there was a bug and I will fix it.

@abetomo
Copy link
Contributor Author

abetomo commented Jul 24, 2018

Fixed.
In my project, there was no problem as a result of new creation and update test.

@DeviaVir DeviaVir merged commit d09e1d3 into motdotla:master Jul 24, 2018
@abetomo abetomo deleted the feature_function_update_using_s3 branch July 24, 2018 15:37
@teebu
Copy link

teebu commented Jul 24, 2018

works, how long does it take to appear on npmjs?

@abetomo abetomo mentioned this pull request Aug 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: upload to s3 and deploy from bucket
3 participants
@abetomo @teebu @DeviaVir