Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and unnecessary package removal #307

Merged
merged 2 commits into from
Jun 4, 2017
Merged

Refactoring and unnecessary package removal #307

merged 2 commits into from
Jun 4, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Jun 3, 2017

  • Remove unnecessary else (lib/schedule_events.js)
    • It is unnecessary because it is returning in the if statement
  • Remove unused package

@abetomo
Remove unnecessary else
8562237 
It is unnecessary because it is returning in the if statement
@abetomo
Remove unused package
715a5ba
DeviaVir
DeviaVir approved these changes Jun 4, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@DeviaVir DeviaVir merged commit ada18aa into motdotla:master Jun 4, 2017
@abetomo abetomo deleted the refactor_schedule_events branch June 5, 2017 01:20
@DeviaVir DeviaVir mentioned this pull request Jun 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir