Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change short option of --tracingConfig to -c #385

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Change short option of --tracingConfig to -c #385

merged 3 commits into from
Nov 9, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Nov 9, 2017

I changed the short option of --tracingConfig to -c.
Since there is little vacancy of the short option, I made this but please point out if there is anything good.

fix #384

DeviaVir
DeviaVir approved these changes Nov 9, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 and great test

@DeviaVir DeviaVir merged commit 0ba8477 into motdotla:master Nov 9, 2017
@abetomo abetomo deleted the fix_short_option branch November 10, 2017 01:24
@DeviaVir DeviaVir mentioned this pull request Dec 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-T appears twice in deploy command options
2 participants
@abetomo @DeviaVir