Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout preview missing default style #16

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: layout preview missing default style #16

merged 1 commit into from
Oct 16, 2024

Conversation

motea927
Copy link
Owner

πŸ”— Linked issue

#12

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

After merging #13, the layout preview lost its default styles. This occurred because the layout preview component is teleported to the body, which prevents the shadow DOM styles from being applied correctly. To address this, we introduced a dynamic style injection to ensure the layout preview retains its default styles.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly (for new feature).

@motea927 motea927 merged commit 5d16876 into main Oct 16, 2024
4 checks passed
@motea927 motea927 deleted the dev branch October 16, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant