Add support for AnimatePresence when using shadow DOM #2830
+55
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehbelinda
force-pushed
the
tehbelinda/animate-poplayout-shadowdom
branch
2 times, most recently
from
58d608b
to
88dd5de
Compare
|
Hey @mattgperry, do you know what the process is to get this change merged? |
tehbelinda
force-pushed
the
tehbelinda/animate-poplayout-shadowdom
branch
from
88dd5de
to
8443249
Compare
…esence with mode === `popLayout` By default this was using document.head, but that is not always available to where it's rendered, e.g. when using the shadow DOM. Instead, pass the shadow root to the new `parentDOM` prop
tehbelinda
force-pushed
the
tehbelinda/animate-poplayout-shadowdom
branch
from
8443249
to
c1f485c
Compare
for cases where it may not exist, e.g. headless tests
|
hi @mattgperry the pipeline is passing and I just updated the latest conflicts on the CHANGELOG, let me know if you are able to review and approve this or is there someone else I should ping? thanks! |
|
@kurtextrem is this something you can help with? |
tehbelinda
changed the title
popLayout
|
@SaeWooKKang @mattgperry this is a blocker for me would be huge to get this merged 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this was using document.head, but that is not always available to where it's rendered, e.g. when using the shadow DOM. In such cases, this change allows for the shadow root to be passed to the new
parentDOMprop. This change is backwards compatible since we default todocument.headwhen not specified.Fixes #2508