SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior #2841
+95
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g both a SVG text and HTML h1 element
… now identical, move logic to DOMVisualElement
|
@mattgperry The issue is now fixed. I'm happy to provide additional testing or troubleshooting if needed before merging. Quick question about #1877: Was the decision intentional to implement |
simonkarman
changed the title
simonkarman
commented
Oct 23, 2024
| delete this.childSubscription | ||
| } | ||
|
|
||
| const { children } = this.props |
There was a problem hiding this comment.
It might still be worth exploring why a children prop is set on the SVG elements.
Screenshot from example in Chrome macOS: http://localhost:9990/?example=SVG-Text-MotionValue-Child
|
Hi @mattgperry, what is the process of getting this PR merged? The pipeline succeeds and there are no conflicts with the main branch. Let me know if you are able to review and approve this. Or let me know if there is someone else I should reach out to. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue as described in: #2578
Feature was introduced in: #1877
Changelog:
motion.text) now update when given aMotionValueas children, matching HTML element behavior.