Yet another Python3 wip #2258
Yet another Python3 wip #2258
Conversation
|
I don't count as authority, but why oh why did you make non-Python3 related changes, too? Like add Motion 4.4 support, and change configs, and alter source code formatting? Just the formatting changes make reviewing this awfully more tedious than it need to, and mixing two major changes like Python3 and Motion4.4 in the same bunch (even in the same feature branch) is IMO just wrong way to do things. |
|
It's a voluntary contribution. Pull it if you like, close the PR if not. |
|
Curious attitude you have. But as I said, I'm no authority, and my comment was meant to be helpful so that your contribution doesn't get wasted. But it's the project owner's call. |
|
To deep conflicts to resolve. I opened a partial PR where we need to add other wanted changes from this PR: #2318 |
|
Please rebase. |
|
This cannot really be rebased as of too many conflicts. See my post above with the PR based on a conservative rebase, i.e. consequently preferring current dev code. But it is possible that other changes from here are good to manually port to dev. |
|
Why |
|
@cclauss |
Use floor division instead of regular division follow by int() conversion. Also remove redundant parenthesis. Taken from #2258 by @Mictronics. Signed-off-by: MichaIng <micha@dietpi.com>
Use floor division instead of regular division follow by int() conversion. Also remove redundant parenthesis. Taken from #2258 by @Mictronics. Signed-off-by: MichaIng <micha@dietpi.com>
|
|
||
| elif self._auth_mode == 'digest': # in digest auth mode, the header is built upon receiving 401 | ||
| self.write(b'GET / HTTP/1.1\r\n\r\n') | ||
| self.write(b'GET /%d/stream HTTP/1.1\r\n\r\n' % self._camera_id) |
There was a problem hiding this comment.
@Mictronics
These GET requests are the only change which is not yet applied the same or similar way in dev already. Since generally MJPG cameras and the MJPG stream to browser work fine, can you explain the rationale behind this change?
|
Marking this as closed now. The open question above remains, but since everything works as expected it is not a mandatory change and can be done any time later via dedicated PR and proper explanation why and how to test. |
Feel free to review, test and pull in if you like.
Test environment 1:
Test environment 2: