rename Savon::Response#hash to Savon::Response#full_hash (savonrb#985)

* rename Savon::Response#hash to Savon::Response#full_hash
* fix tests so they pass in both rack 2 and rack 3

lib/savon/response.rb

@@ -54,8 +54,8 @@ def to_array(*path)
       result.kind_of?(Array) ? result.compact : [result].compact
     end
 
-    def hash
-      @hash ||= nori.parse(xml)
+    def full_hash
+      @full_hash ||= nori.parse(xml)
     end
 
     def xml
@@ -79,7 +79,7 @@ def xpath(path, namespaces = nil)
     end
 
     def find(*path)
-      envelope = nori.find(hash, 'Envelope')
+      envelope = nori.find(full_hash, 'Envelope')
       raise_invalid_response_error! unless envelope.is_a?(Hash)
 
       nori.find(envelope, *path)

spec/savon/mock_spec.rb

@@ -37,7 +37,7 @@
 
   it "accepts a Hash to specify the response code, headers and body" do
     soap_fault = Fixture.response(:soap_fault)
-    response = { :code => 500, :headers => { "X-Result" => "invalid" }, :body => soap_fault }
+    response = { :code => 500, :headers => { "x-result" => "invalid" }, :body => soap_fault }
 
     savon.expects(:authenticate).returns(response)
     response = new_client(:raise_errors => false).call(:authenticate)

spec/savon/options_spec.rb

@@ -405,7 +405,7 @@ def to_s
         client = new_client(:endpoint => @server.url, :log => true)
         client.call(:authenticate)
       }
-      soap_header = stdout.string.include? "Content-Type"
+      soap_header = stdout.string.downcase.include? "content-type"
       expect(soap_header).to be true
     end
 
@@ -850,7 +850,7 @@ def to_s
 
       response = client.call(:authenticate, :xml => Fixture.response(:authentication))
 
-      expect(response.hash["soap:envelope"]["soap:body"]).to include("ns2:authenticate_response")
+      expect(response.full_hash["soap:envelope"]["soap:body"]).to include("ns2:authenticate_response")
     end
   end
 
@@ -880,7 +880,7 @@ def to_s
       client = new_client(:endpoint => @server.url(:repeat), :convert_response_tags_to => lambda { |tag| tag.snakecase.upcase })
       response = client.call(:authenticate, :xml => Fixture.response(:authentication))
 
-      expect(response.hash["ENVELOPE"]["BODY"]).to include("AUTHENTICATE_RESPONSE")
+      expect(response.full_hash["ENVELOPE"]["BODY"]).to include("AUTHENTICATE_RESPONSE")
     end
 
     it "accepts a block in the block-based interface" do
@@ -895,7 +895,7 @@ def to_s
         locals.xml Fixture.response(:authentication)
       end
 
-      expect(response.hash["ENVELOPE"]["BODY"]).to include("AUTHENTICATE_RESPONSE")
+      expect(response.full_hash["ENVELOPE"]["BODY"]).to include("AUTHENTICATE_RESPONSE")
     end
   end
 

spec/savon/response_spec.rb

@@ -138,7 +138,7 @@
     describe "##{method}" do
       it "should return the SOAP response body as a Hash" do
         expect(soap_response.send(method)[:authenticate_response][:return]).to eq(
-          Fixture.response_hash(:authentication)[:authenticate_response][:return]
+          Fixture.full_hash(:authentication)[:authenticate_response][:return]
         )
       end
 
@@ -180,7 +180,7 @@
     context "when the given path exists" do
       it "should return an Array containing the path value" do
         expect(soap_response.to_array(:authenticate_response, :return)).to eq(
-          [Fixture.response_hash(:authentication)[:authenticate_response][:return]]
+          [Fixture.full_hash(:authentication)[:authenticate_response][:return]]
         )
       end
 
@@ -206,7 +206,7 @@
   describe "#hash" do
     it "should return the complete SOAP response XML as a Hash" do
       response = soap_response :body => Fixture.response(:header)
-      expect(response.hash[:envelope][:header][:session_number]).to eq("ABCD1234")
+      expect(response.full_hash[:envelope][:header][:session_number]).to eq("ABCD1234")
     end
   end
 

spec/support/fixture.rb

@@ -9,9 +9,9 @@ def [](type, fixture)
       fixtures(type)[fixture] ||= read_file type, fixture
     end
 
-    def response_hash(fixture)
-      @response_hash ||= {}
-      @response_hash[fixture] ||= nori.parse(response(fixture))[:envelope][:body]
+    def full_hash(fixture)
+      @full_hash ||= {}
+      @full_hash[fixture] ||= nori.parse(response(fixture))[:envelope][:body]
     end
 
     TYPES.each do |type, ext|