Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first of all, great work on the project 😄
So, onto the PR:
Issue
We use this package in an application that is running Node in an Alpine Linux container where there is no
bash
, onlysh
is available.Proposed solution
Changing shell scripts to be compatible with
sh
, which will make it compatible with environments wherebash
is not available, such as Alpine Linux.I noticed the use of bash was in only two scripts. Aside from renaming the scripts and references from
*.bash
to*.sh
, there was only one code change that was needed, in the conditional in thelist-npx-cache
script the test ([[
) operator had to be changed to[
to be compatible withsh
.Let me know if these changes are acceptable so we can upgrade to the latest release of the project.
Thanks, have a great week!