-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement #105 #120
Implement #105 #120
Conversation
Missed the most important file! |
I also renamed the builders, because they were getting run during testing due to their name containing the magic word "test".
# Conflicts: # Qt.py
Without these lines, tests may look within any Python file and throw errors unrelated to tests (in this case, SyntaxError in Python 3 for file(s) produced by build_membership.py).
This is nice. I'm checking the code out now. |
I've never seen the use of |
f.write(contents) | ||
|
||
|
||
# Don't consider these members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind expanding this comment on why these are not considered members?
Is it because they are either internals (__something__
) or binding-specific (doesn't have an equivalent in PySide2)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is it because these have no no Qt4-equivalent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment.
Good job! This is an awesome addition to the project @mottosso 😀 Have you seen that the Travis CI tests output looks a bit garbled? |
That's the generated membership test. I figure, for now, it might be worth keeping an eye on exactly how it's working since it's a bit ad-hoc. |
Ok, it's not perfect, but will do for a first pass. Let's keep it in mind for future improvements and corrections; in particular about including members as they become available through PySide2. |
Sounds good! |
Here's one way of achieving #105.
Some problems include (1), PySide2 not yet being complete, so things like
QtOpenGL
is missing and (2) PySide2 including quite a few unique members compared to PyQt5, which should theoretically be quite similar.Example output
Here's what I got in this initial commit.