Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #139 #140

Merged
merged 4 commits into from
Sep 21, 2016
Merged

Implement #139 #140

merged 4 commits into from
Sep 21, 2016

Commits on Sep 20, 2016

  1. Implement mottosso#139

    @mottosso
    mottosso committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    f97fde5 View commit details
    Browse the repository at this point in the history

  2. Cleanup 

    This points out a potential problem with a previous fix for compatibility with https://github.com/pyqt/python-qt. Before, these members were tested against existing members, but now they are blindly added via `setattr`. It's safe, since we've already tested these and know for sure that they aren't being overwritten. But it still opens the door for these to one day override a newly added member.

Luckily, this is only relevant until the next major release, upon which they are all discarded.
    @mottosso
    mottosso committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    032cfdb View commit details
    Browse the repository at this point in the history

  3. Rename QtShim to QtCompat

    @mottosso
    mottosso committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    24a7e59 View commit details
    Browse the repository at this point in the history

  4. Add note on how testing works and nosepipe.

    @mottosso
    mottosso committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    87d57aa View commit details
    Browse the repository at this point in the history