python2.6 support #245
python2.6 support #245
Conversation
|
|
Qt.py
Outdated
| @@ -760,14 +760,22 @@ def _new_module(name): | |||
| return types.ModuleType(__name__ + "." + name) | |||
|
|
|||
|
|
|||
| def _import_module(name): | |||
| """ | |||
| import_module is a replacement for importlib. | |||
Qt.py
Outdated
| @@ -760,15 +760,23 @@ def _new_module(name): | |||
| return types.ModuleType(__name__ + "." + name) | |||
|
|
|||
|
|
|||
| def _import_sub_module(module, name): | |||
| """import_sub_module will mimic the functionality of importlib.import_module""" | |||
| module = __import__(module.__name__ + "." + name) | |||
Qt.py
Outdated
| @@ -760,15 +760,23 @@ def _new_module(name): | |||
| return types.ModuleType(__name__ + "." + name) | |||
|
|
|||
|
|
|||
| def _import_sub_module(module, name): | |||
| """import_sub_module will mimic the functionality of importlib.import_module""" | |||
There was a problem hiding this comment.
line too long (83 > 79 characters)
|
I don't know Travis well enough to setup 2.6 tests. Do we need/want them? I think it would be somewhere in the docker setup that I would add support for 2.6 I think. |
The question is whether all the bindings (of the versions we're using) will build on Python 2.6... I'm not sure. I would have to try that. For this PR, I suggest we skip such a test for now. I can add Python 2.6 support the next time I'm working on the #234 and see what happens. |
It keeps *hounding* me
|
Hey so I fixed the houndci issues, I am changing the title of this to remove the "WIP" |
|
Completely missed this one, sorry about that. I think this looks good. @Ahuge would you happen to have tested this (in production)? |
|
I think I've got a copy of it at work, I'll confirm in a bit |
|
Yeah confirmed the branch py26-support works in production. |
|
I'd say let's just merge this then. |
Working on #235
Don't merge yet. I haven't had a change to do it all yet or run the unittests yet.