Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix loadUi widget placement issue #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MagicRedDeer
Copy link

This is an attempt to fix #323. Where a UI loaded in PySide from a .ui file does not show up at the top of the parent widget as expected.

This solution creates a new widget as a child or the "base instance" and then uses the new widgets layout or central widget on the base instance.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@mottosso
Copy link
Owner

Thanks for this. Could you implement a test for this as well? That way it'll get run during CI and ensure it works for all bindings on all platforms. Also if you could post a reproducible we could run locally as well, to confirm it works visually that would be great.

@mottosso
Copy link
Owner

Hi @MagicRedDeer, thanks again for submitting this PR. I know writing tests are a drag, but if you could paste something even in a comment, then we could run it on our end and confirm it works and doesn't break anything else. That would help this PR getting merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog with loadUi placement inconsistency on show
3 participants