-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace header profile widgets with profiles dock page #110
Replace header profile widgets with profiles dock page #110
Conversation
Like I've said in the chat, this is excellent work, thanks for this @davidlatwe! What do we think about the space left behind where the old profile widget was? Maybe we could now shift all icons to the left, and close that gap? |
Oh yes, about the layout of those dock page toggle buttons on the header after this change, here's what I think : I was actually thinking that we could change them into like the style I found in PyCharm : Which is simple tiny icon + label style, and that will be less screen space used, and user would be a bit more clearer about what is that button/page is for with the label. (Allzpark logo will also be tinified and remain on the right side I guess) But that's the future plan in my mind. What do you think ? For now, I think I would go option 1), which is push all of them to the left side. :P |
Hmmmmmmmmm :D I suppose it's subjective, but I find that visual more noisy, even though it takes up less space. I find that buttons invite curiosity and once you've found the buttons you're looking for you are unlikely to have to read its name again. But, subjective, so I can appreciate that some may prefer the PyCharm style. I would make it an (non-default) option. Like the "Use small taskbar icons" in Windows or Unreal Engine.
If possible, I think it would be most visually clear to move only the profile to the left, and keep the docking buttons in the centre like the original design. It gives them a distinct visual difference. Having them bunched together implies they perform a similar action. |
Good idea 👍🏼
Yeah that's true. See if I can pull this off today. 💪🏼 |
Oh! Hmmmmm, I see how it works now. That profile button is actually just another dock button, like the others. :D I dunno man, I might take back what I said about having it be separate from the other buttons, it does exactly the same thing. Hmmmm. What do you think? What feels right? I kind of like it to the left, because it is special in that it will show the project icon, and it is probably more used then the others.
Good question. I'll trust your judgement on this. |
Yeah, it is a special one indeed, so I like it solely on the left side as well. :P Previously I prefer to push those dock toggle buttons to the left side all together was simply because easier to implement, but turns out it wasn't that hard (fe4dc92). Now I think the functionality is good to go, but I'd like to polish the icons, and once I done that I think we could bump the version up to |
Sounds good to me. Thanks @davidlatwe |
Proposal
Instead of using line-edit widget, change to use treeview to view/select/activate profiles.
Here's the result :
And a close look on the profile tool bar :
Features
star
button.filter
button.filter
button will still match and present.version
button._data["category"]
. The default category name is"profiles"
as shown in above image if that attribute is not presented.