Skip to content

Commit

Permalink
chore: fix go lint
Browse files Browse the repository at this point in the history
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
  • Loading branch information
moul committed Jul 23, 2022
1 parent e32fad4 commit 3ba20cd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion internal/dvserver/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts
}
svc.httpListenerAddr = listener.Addr().String()
srv := http.Server{
Handler: r,
ReadHeaderTimeout: 2 * time.Second, // nolint:gomnd
Handler: r,
}
svc.workers.Add(func() error {
httpLogger.Debug("starting HTTP server", zap.String("bind", opts.HTTPBind))
Expand Down
4 changes: 2 additions & 2 deletions internal/githubprovider/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error {

// assignees
for _, assignee := range input.Assignees {
assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck // false-positive?
assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck
if err != nil {
return fmt.Errorf("from user: %w", err)
}
Expand All @@ -106,7 +106,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error {

// labels
for _, label := range input.Labels {
labelRet, err := fromLabel(batch, label) // nolint:typecheck // false-positive?
labelRet, err := fromLabel(batch, label) // nolint:typecheck
if err != nil {
return fmt.Errorf("from label: %w", err)
}
Expand Down

0 comments on commit 3ba20cd

Please sign in to comment.