Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ws to v8.18.0 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Mar 31, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 8.12.1 -> 8.18.0 age adoption passing confidence

Release Notes

websockets/ws (ws)

v8.18.0

Compare Source

Features

v8.17.1

Compare Source

Bug fixes

A request with a number of headers exceeding the[server.maxHeadersCount][server.maxHeadersCount]
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 0 }, function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: wss.address().port
  });

  request.end();
});

The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the
    [--max-http-header-size=size][--max-http-header-size=size] and/or the [maxHeaderSize][maxHeaderSize] options so
    that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

v8.17.0

Compare Source

Features

  • The WebSocket constructor now accepts the createConnection option (#​2219).

Other notable changes

  • The default value of the allowSynchronousEvents option has been changed to
    true (#​2221).

This is a breaking change in a patch release. The assumption is that the option
is not widely used.

v8.16.0

Compare Source

Features

  • Added the autoPong option (01ba54e).

v8.15.1

Compare Source

Notable changes

  • The allowMultipleEventsPerMicrotask option has been renamed to
    allowSynchronousEvents (4ed7fe5).

This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.

v8.15.0

Compare Source

Features

  • Added the allowMultipleEventsPerMicrotask option (93e3552).

v8.14.2

Compare Source

Bug fixes

  • Fixed an issue that allowed errors thrown by failed assertions to be
    swallowed when running tests (7f4e1a7).

v8.14.1

Compare Source

Bug fixes
  • Improved the reliability of two tests for CITGM (fd3c64c).

v8.14.0

Compare Source

Features

  • The WebSocket constructor now accepts HTTP(S) URLs (#​2162).
  • The socket argument of server.handleUpgrade() can now be a generic
    Duplex stream (#​2165).

Other notable changes

  • At most one event per microtask is now emitted (#​2160).

v8.13.0

Compare Source

Features

  • Added the finishRequest option to support late addition of headers (#​2123).

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title fix(deps): update dependency ws to v8.13.0 fix(deps): update dependency ws to v8.13.0 - autoclosed Apr 3, 2023
@renovate renovate bot closed this Apr 3, 2023
@renovate renovate bot deleted the renovate/ws-8.x-lockfile branch April 3, 2023 23:41
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.13.0 - autoclosed fix(deps): update dependency ws to v8.13.0 Apr 4, 2023
@renovate renovate bot reopened this Apr 4, 2023
@renovate renovate bot restored the renovate/ws-8.x-lockfile branch April 4, 2023 09:48
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 415d6a2 to 1f78e16 Compare September 7, 2023 02:44
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.13.0 fix(deps): update dependency ws to v8.14.0 Sep 7, 2023
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.14.0 fix(deps): update dependency ws to v8.14.1 Sep 9, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 1f78e16 to 2cf2b79 Compare September 9, 2023 14:46
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 2cf2b79 to 91ab506 Compare September 19, 2023 17:59
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.14.1 fix(deps): update dependency ws to v8.14.2 Sep 19, 2023
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.14.2 fix(deps): update dependency ws to v8.15.0 Dec 10, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch 2 times, most recently from 540c6c8 to b96633c Compare December 13, 2023 05:47
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.15.0 fix(deps): update dependency ws to v8.15.1 Dec 13, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from b96633c to 7a44d20 Compare December 27, 2023 08:39
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.15.1 fix(deps): update dependency ws to v8.16.0 Dec 27, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 7a44d20 to f0a93ca Compare May 1, 2024 17:58
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.16.0 fix(deps): update dependency ws to v8.17.0 May 1, 2024
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.17.0 fix(deps): update dependency ws to v8.17.1 Jun 17, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from f0a93ca to c42224c Compare June 17, 2024 08:12
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.17.1 fix(deps): update dependency ws to v8.18.0 Jul 3, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from c42224c to f2cb853 Compare July 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants