Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #89 warrants a semver-major release, I thought I'd cram some more breaking changes that I'd like to do at the same time. So far the PR:
rbush(...)
tonew RBush(...)
, a more idiomatic ES approach — since ES forbids calling classes withoutnew
, and we still want to expose an extendable class rather than a factory.format
option. While convenient, it still doesn't feel good to rely on eval while developers increasingly adopt strict CSP rules. If we remove it, we'll just document dealing with custom formats by redefiningtoBBox
,compareMinX
andcompareMinY
methods.To do:
format
option?cc @rowanwins @tschaub thoughts?