chore: update PHPUnit to latest version #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
3 times, most recently
from
dfdf9dd to
6b15abd
Compare
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
from
6b15abd to
928ceae
Compare
SMillerDev
requested review from
pprkut,
brianstoop,
marcella-galambos-move and
josemarper
brianstoop
reviewed
Nov 19, 2024
Comment on lines
-73
to
69
| ->withConsecutive( | ||
| ->willReturnMap([ | ||
| [ 'Trying to initialize HTTP/2 backend...' ], | ||
| [ 'Initializing HTTP/2 backend with certificate.' ], | ||
| [ 'Retry to connect (1/3)...' ], |
There was a problem hiding this comment.
I get that this works but what exactly does this test now? IIRC, if the ReturnMap array is empty it would also succeed, so what does this add?
There was a problem hiding this comment.
willReturnCallback maybe?
There was a problem hiding this comment.
How does willReturnCallback work here?
There was a problem hiding this comment.
this is what i've found: https://tomasvotruba.com/blog/how-to-upgrade-deprecated-phpunit-with-consecutive
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
2 times, most recently
from
84f360e to
10664ae
Compare
marcella-galambos-move
requested changes
Nov 29, 2024
Comment on lines
-73
to
69
| ->withConsecutive( | ||
| ->willReturnMap([ | ||
| [ 'Trying to initialize HTTP/2 backend...' ], | ||
| [ 'Initializing HTTP/2 backend with certificate.' ], | ||
| [ 'Retry to connect (1/3)...' ], |
There was a problem hiding this comment.
willReturnCallback maybe?
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
2 times, most recently
from
a844c11 to
4827ac3
Compare
pprkut
requested changes
Dec 4, 2024
ApnsPHP/Message/Tests/CustomMessageGetPayloadDictionaryTest.php
Outdated
Show resolved
Hide resolved
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
from
4827ac3 to
2c2bd3d
Compare
SMillerDev
force-pushed
the
chore/test/update_phpunit
branch
from
2c2bd3d to
6c023cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.