Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset remote if URL changed #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reset remote if URL changed #4

wants to merge 1 commit into from

Conversation

SMillerDev
Copy link
Contributor

The test is incomplete

pprkut
pprkut requested changes May 16, 2024
View reviewed changes
tests/install.bats
Comment on lines +126 to +127
# create new commit in repository and tag
git -C "${TEST_REPOS_DIR}/alpha-lib" remote set-url origin https://moveagency.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That command references the original repo, not the clone. Also, the comment is wrong

tests/install.bats
[ "${status}" -eq 0 ]
[ "${lines[0]}" = "Installing Alpha...done" ]

assert_lib_installed Alpha-1.0 "${tag_alpha_lib_revision_hash}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just verifies the hash is as expected, but we only have the commits from the original clone. To properly test this decomposer install would have to fetch new commits, and we'd have to verify that the remote after running decomposer install matches what's in decomposer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pprkut pprkut pprkut requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SMillerDev @pprkut