Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SPDX SBOM generation option #5

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SMillerDev
Copy link
Contributor

Adding the generation of an SBOM in the SPDX format

@SMillerDev SMillerDev force-pushed the feat/spdx branch 9 times, most recently from f43f78a to e0007bf Compare September 12, 2023 08:54
Comment on lines +1 to +3
. += {
name: $name,
SPDXID: "SPDXRef-\($name)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changelog, we'd need the project version in here too. I see examples adding it to the name, which I suppose would be good enough. We could extract it from there again. A dedicated version field might be easier, though I haven't really found that in the spec. Just in some examples of other generators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With version, you are referring to commit hashes right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, anything we can use as input for git log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git log 0.8.0-1-g6ed6e9fa..

This works, for example, so the output of git describe would be possible too

Comment on lines +30 to +32
jsonschema:
name: jsonschema
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be better in a separate workflow. I think the curl is not enough and we need an actual git clone to work with, and that would open up the road to a testsuite where we clone and test with multiple different repos.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants