Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci updates #1122

Merged
merged 2 commits into from
Sep 6, 2024
Merged

circleci updates #1122

merged 2 commits into from
Sep 6, 2024

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Sep 6, 2024

this updates circleci requirements and python version. it should make doc creation dependency installation faster so it doesn't time out as easily.

@bmos bmos force-pushed the patch-2 branch 4 times, most recently from 62f43db to df0ecdd Compare September 6, 2024 14:11
@bmos bmos marked this pull request as ready for review September 6, 2024 14:19
@shaunagm
Copy link
Collaborator

shaunagm commented Sep 6, 2024

I'm a little concerned that only 4 tests are being run. In my experience that's a sign of some kind of formatting or configuration error, although I could be wrong!

@anzelpwj
Copy link
Contributor

anzelpwj commented Sep 6, 2024

@shaunagm that's because the other tests specify that they only run when certain files (which does not include the Circle CI YAML) are changed.

on:
  pull_request:
    paths:
      - .github/workflows/pip-install.yml
      - requirements.txt
      - setup.py
  push:
    paths:
      - .github/workflows/pip-install.yml
      - requirements.txt
      - setup.py
  workflow_dispatch:
on:
pull_request:
  paths:
    - .github/workflows/test.yml
    - requirements*.txt
    - "**.py"
push:
  paths:
    - .github/workflows/test.yml
    - requirements*.txt
    - "**.py"
workflow_dispatch:

@shaunagm shaunagm merged commit 30be14b into move-coop:main Sep 6, 2024
4 checks passed
@bmos bmos deleted the patch-2 branch September 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants