This repository has been archived by the owner on May 4, 2024. It is now read-only.
[inlining] Revised inlining implementation #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrwg
force-pushed
the
inline2
branch
4 times, most recently
from
289926b to
4c902f4
Compare
This is a new implementation of inlining which uses eager (call-by-value) parameter passing. This makes inline functions semantically fully compatible with regular functions. The new implementation also fixes some name clash problems. The suggested functionals for vector have been added and tested. Moreover, documentation has been added to the Move reference.
meng-xu-cs
approved these changes
Jan 17, 2023
| f(_x); | ||
| } | ||
|
|
||
| public fun test_shadowing() { |
There was a problem hiding this comment.
This is a mind-tweaking (in a good way) test case....
This actually fundamental in the entire working of this PR. There is e.g. code where we need do the following: Subsequent phases expect that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of inlining which uses eager (call-by-value) parameter passing. This makes inline functions semantically fully compatible with regular functions. The new implementation also fixes some name clash problems.
Functionals for vector have been added and tested. Moreover, documentation has been added to the Move reference.
The related AIP is here: aptos-foundation/AIPs#36