Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise XML-RPC parameter lookup #155

Closed
JafarAbdi opened this issue Jan 17, 2020 · 1 comment
Closed

Revise XML-RPC parameter lookup #155

JafarAbdi opened this issue Jan 17, 2020 · 1 comment

Comments

@JafarAbdi
Copy link
Member

JafarAbdi commented Jan 17, 2020 •
edited
Loading

One suggested approach, 2
@henningkayser
Copy link
Member

henningkayser commented Jan 31, 2020 •
edited
Loading

I think currently your proposed yaml approach is the way to go. In addition, I think we should make use of rclcpp::Node::declare_parameter() for all (even optional) parameters. This enables much better control about what parameters should be provided, for instance by providing additional descriptions with the declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henningkayser @JafarAbdi