Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moveit simple controller manager doesn't respond to changes of trajectory_execution.execution_duration_monitoring parameter #760

Closed
Thijsons opened this issue Oct 27, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Thijsons
Copy link

Description

To make the UR10e robot work properly with its internal speed set to low values the 'trajectory_execution.execution_duration_monitoring' parameter of the simple controller manager needs to be changed to false, see here.

setting the 'trajectory_execution.execution_duration_monitoring' parameter to false via a launch file does not seem to affect the simple controller manager? Checking the parameter on the parameter server does show its value to be false.

Setting it manually via
ros2 service call /moveit_simple_controller_manager/set_parameters rcl_interfaces/srv/SetParameters "{parameters: [{name: "trajectory_execution.execution_duration_monitoring", value: {type: 1, bool_value: False}}]}"
does work.

Your environment

  • ROS Distro: Foxy
  • OS Version: e.g. Ubuntu 20.04
  • Source, foxy branch

Steps to reproduce

adjust the parameter in the launch file in the way described.

Expected behaviour

This parameter should be altered in the simple controller manager and change the behavior of the controller

Actual behaviour

The parameter is set on the ros2 parameter server, but the simple controller manager does not seem affected.

@AndyZe
Copy link
Member

AndyZe commented Oct 27, 2021

Thanks for pointing this out! In future MoveIt releases, I think trajectory execution duration monitoring should be dropped and we'll allow ros2_control to handle it (which it does already).

That doesn't help you with Foxy, though... It would be helpful if you could make a PR.

@henningkayser henningkayser added the bug Something isn't working label Jun 2, 2022
@henningkayser
Copy link
Member

#996 has fixed this, I'm backporting to Foxy

@henningkayser
Copy link
Member

#1898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants