Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Servo] Update servo tutorials #734

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

ibrahiminfinite
Copy link
Contributor

@ibrahiminfinite ibrahiminfinite commented Aug 8, 2023

Description

This PR updates the tutorials for MoveIt Servo as part the recent refactor moveit/moveit2#2224.

Checklist

Pining @sea-bass @AndyZe for review.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

Tutorials are in good shape -- my only major suggestion here is that for this repo we don't directly link to code using its URL, and instead there are all these handy RST directives to help link code while keeping things in sync with different versions.

Besides that, mostly editorial stuff.

doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
doc/examples/realtime_servo/src/pose_tracking_tutorial.cpp Outdated Show resolved Hide resolved
doc/examples/realtime_servo/src/pose_tracking_tutorial.cpp Outdated Show resolved Hide resolved
doc/examples/realtime_servo/realtime_servo_tutorial.rst Outdated Show resolved Hide resolved
@sea-bass sea-bass requested a review from AndyZe August 8, 2023 13:01
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, and the source code updates are needed to make the tutorials build on main anyhow, so let's go for it!

@tylerjw
Copy link
Member

tylerjw commented Aug 8, 2023

Thank you for updating this!

@tylerjw tylerjw merged commit 3e38458 into moveit:main Aug 8, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants