Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx version for CI to pass on main #854

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Update sphinx version for CI to pass on main #854

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd914c9
Update sphinx version
Abishalini Jan 15, 2024
ab7328e
Pin sphinx version to >=5.0.0
Abishalini Jan 15, 2024
c17a559
Set language to en
Abishalini Jan 15, 2024
87010d3
Set sphinx-tabs version
Abishalini Jan 15, 2024
508a038
Update docutils
Abishalini Jan 15, 2024
ec511f1
Update requirements.txt
sea-bass Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pip
docutils==0.16
sphinx==4.3.2
sphinx
Copy link
Contributor

@sea-bass sea-bass Jan 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To minimize breakages, do you maybe want to specify a version after all?

The one that was downloaded was 7.2.6 according to https://github.com/ros-planning/moveit2_tutorials/actions/runs/7531539359/job/20500319203?pr=854#step:4:82

You can also use something like sphinx>=5.0.0 if you just want to skirt around the immediate error but give users wiggle room when building locally.

Generally for these things it's good for the pip requirements to be pinned to actual versions and for any updates to be deliberate.

sphinx-tabs
sphinx-multiversion
sphinx-rtd-theme
Expand Down
Loading