BEFORE_DOCKER_SCRIPT

[rhaschke]

(Optionally) allow execution of a script before starting the docker container.
Addresses moveit/moveit#1320 (comment).

[davetcoleman]

This feels clunky, what do you think of instead running the IKFast test similar to how clang-format is run? In the Travis test matrix we could have:

 - ROS_DISTRO=melodic  ROS_REPO=ros  TEST=ikfast                                                             

Or maybe to help me better understand this new feature, could you add a small section to the moveit_ci README explaining this new function?

[rhaschke]

What do you think of instead running the IKFast test similar to how clang-format is run?

That's not possible. The intended script doesn't run the test (as in clang-format), but it creates the ikfast plugins from the templates. The generated plugins then need to be build as part of the catkin workspace, such that they will be found as ROS packages by the prepared kinematics tests.

@davetcoleman I added the requested README comment.

[rhaschke]

@davetcoleman Was there a special reason that you approved but didn't merged?

[davetcoleman]

I wasn't super excited about it (see my feedback) so wanted to give anyone else a chance to review, or for you to have a second thought.

[rhaschke]

The BEFORE_DOCKER_SCRIPT is definitely needed to run another docker container before, which is needed to test the ikfast-generation pipeline. So know 2nd thought required on my side ;-)