Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

New Continuous Integration Method #309

Closed
davetcoleman opened this issue Jul 8, 2016 · 4 comments
Closed

New Continuous Integration Method #309

davetcoleman opened this issue Jul 8, 2016 · 4 comments

Comments

@davetcoleman
Copy link
Member

I've created yet another continuous integration script - its a combination of the strengths of industrial_ci and the simplicity of @jbohren and my original MoveIt! travis script that was recently revitalized by @rhaschke. The show-stopper problem with the simple .travis.yml script is that it doesn't support ROS Kinetic, and I've been working hard to get the Kinetic code working so this is important.

The problem with the industrial_ci script are many:

It is certainly possible to fix these things in industrial_ci, as I tried but the turn around time seemed kind of slow because changing anything in this script could potentially break many other projects in the ROS Industrial project using industrial_ci. @rhaschke came to the same conclusion

Thinking more about the issue, I came to the conclusion that it is hard to server the two goals of i) printing the commands from travis.sh but ii) not printing the commands in called functions or sourced scripts.
The output in the web interface is cluttered already in the overview (with travis_time_start, set +x, and <<< >>>. Hence, for MoveIt, I resumed to standard travis.yml files, improving them according to some inspiration gained from your script. I like the result much better - but that's my subjective view of course.

I've addressed his issue by making the console output really pretty. This new script uses customized MoveIt! Docker containers.

So I propose creating a moveit_ci repo and moving my https://github.com/davetcoleman/moveit_ci project there. See the README in that project for more details on the script.

This new script has solved building Kinetic for MoveIt!

@davetcoleman
Copy link
Member Author

@130s I'm mostly looking for your feedback

@rhaschke
Copy link
Contributor

rhaschke commented Jul 8, 2016

+1 Great job!

@davetcoleman
Copy link
Member Author

The two places we currently needed this new CI method has been merged, so this issue is resolved for now. It would be nice if all moveit_* repos used this new script, but I don't think its critical at this moment to do so. In fact, I'd rather all those places just got merged into a single repo (future topic). Closing this issue.

@davetcoleman
Copy link
Member Author

Closing this issue since there seems to be acceptance - @130s has started using this script in various places such as ros-interactive-manipulation/manipulation_msgs#8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants