-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement ideas from MoveIt! maintainers #75
Comments
I think it should be possible to combine both again. And the prerelease test could be branched of at https://github.com/ros-planning/moveit_ci/blob/master/travis.sh#L25 So we could use I'd propose the following structure (names may vary):
@130s, @davetcoleman: what do you think? |
I agree re-combining the moveit fork of industrial_ci is probably a good idea so that we can combine our efforts. I forked ours because I identified too many issues that we needed addressed quickly for MoveIt! and I thought it would be easier to move quickly in a fork. Making moveit_ci project-agnostic would have downsides though - we've encoded various simplifying assumptions such as using catkin_tools and only supporting currently supported ROS versions (I/J/K). There are probably others I'm not thinking of. Finally if we consolidated it makes sense to me it would live on ros-industrial or, preferably, some "ros"-all location. But I would like some of the moveit maintainers to have access to review and merge changes. |
And other bigger projects might benefit from providing customized docker images as well.
I don't think that this is a big issue. At a first glance |
+1 for merging the best from both. I'm afraid consolidation could likely lead to slower review process. I ask to add some of you to co-maintain if possible. Both MoveIt! and ROS-i enforce +1-before-merge rule, no culture shock :)
+1 For hosting location, I don't know. Some thoughts:
|
Seems like we should start a discussion on Discourse about a standard ROS CI configuration... it could live in https://github.com/ros-infrastructure/ @wjwwood |
You can put stuff in ros-infrastructure if it would work for any ROS repository and it is specific to the ROS infrastructure (rospkg, rosdep, rosdistro, etc.). There are quite a few options already: http://wiki.ros.org/CIs |
+1 to adding it to the ros-infrastructure |
I think this is moved to #98? |
Thorough feedback from @davetcoleman moveit/moveit_core#309 (comment)
(links are lost so better to look at the original post).
He had to come up with MoveIt! original CI configs since industrial_ci didn't meet its need :/ but understand that.
All of these sound reasonable, and I believe many of them overlap the existing tickets. I just opened this ticket as a pointer.
Travis' output seems higher priority.
The text was updated successfully, but these errors were encountered: