(WIP) Disable individual suction voxels from collision #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for feedback on the general strategy as described in this summary, especially the changes to
SuctionGraspFilter
, as the rest of the code still includes several temporary changes used for testing and needs a bit of extra fixing. Includes #86, so only the last commit is new.This offers a solution to the problem shown in the
TestFilterSuctionIKLowOverlap
test, where setting a low overlap threshold can unexpectedly cause all grasps to be filtered due to collision checking with suction voxels. Instead of throwing out the entire candidate grasp when a collision with a suction voxel is detected, this PR takes the strategy of:AllowedCollisionMatrix
such that we can check collisions only between the suction voxels and objects other than the target boxThis PR still needs work with regard to combining with the suction overlap cutoff filter in a clean way, perhaps reverting to prefiltering and only attaching active voxels. Currently it requires filtering by suction overlap second.