Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use CHOMP and OMPL planners #135

Merged
merged 2 commits into from
May 13, 2022

Conversation

stephanie-eng
Copy link
Contributor

Explicitly use CHOMP, OMPL, and Pilz as planners rather than iterating through all *_planning.yaml files, some of which do not work as of now.

Partially resolves #134

@@ -25,6 +25,7 @@ def generate_launch_description():
.robot_description(file_path="config/panda.urdf.xacro")
.robot_description_semantic(file_path="config/panda.srdf")
.trajectory_execution(file_path="config/gripper_moveit_controllers.yaml")
.planning_pipelines("ompl", ["ompl", "chomp", "pilz_industrial_motion_planner"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.planning_pipelines("ompl", ["ompl", "chomp", "pilz_industrial_motion_planner"])
^ is ompl outside the brackets because it's supposed to be the default? Please add a comment.

I think you should remove pilz_industrial_motion_planner because it doesn't seem to work from the RViz GUI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMPL is by default the default if it applies, so I removed that bit entirely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove pilz_industrial_motion_planner because it doesn't seem to work from the RViz GUI.

doesn't it? I thought the pilz planner is enabled in moveit2 now so where is the open issue?
It's a severe regression if the pilz functionality is not available anymore!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moveit/moveit2#1281 fixed PILZ, it's working now

@AndyZe AndyZe changed the title Explicitly use CHOMP, OMPL, and Pilz planners Explicitly use CHOMP and OMPL planners May 13, 2022
@AndyZe AndyZe merged commit d6f9991 into moveit:ros2 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants