Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libs/movex-core-util): Added new type of EmptyObject #152

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix(libs/movex-core-util): Added new type of EmptyObject #152

merged 2 commits into from
Oct 20, 2023

Conversation

Abhishek-Mallick
Copy link
Contributor

@Abhishek-Mallick Abhishek-Mallick commented Oct 15, 2023 •
edited
Loading

Status:
Closes: #126

@Abhishek-Mallick Abhishek-Mallick mentioned this pull request Oct 15, 2023
Closed
@GabrielCTroia
Copy link
Contributor

Hey @Abhishek-Mallick the compiler seems to fail for this! Not sure if this was supposed to be final 🙌

GabrielCTroia
GabrielCTroia requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@GabrielCTroia GabrielCTroia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one important fix 🙌

libs/movex-core-util/src/lib/core-types.ts Outdated Show resolved Hide resolved
@Abhishek-Mallick
Copy link
Contributor Author

Should work now @GabrielCTroia

@GabrielCTroia
Copy link
Contributor

Thank you for working on this in such a timely manner @Abhishek-Mallick! 🙏🙌

@GabrielCTroia GabrielCTroia merged commit d5131ec into movesthatmatter:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielCTroia GabrielCTroia GabrielCTroia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libs/movex-core-util] Fix linting Errors in File: core-types.ts
2 participants
@Abhishek-Mallick @GabrielCTroia