Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removal of initMovexWithLocalMaster function and related unused dependencies #65

Merged
merged 8 commits into from
Oct 11, 2023

Conversation

Abhishek-Mallick
Copy link
Contributor

Status:
Closes: #59

  • Have safely removed initMovexWithLocalMaster function
  • Unused imports removed

Signed-off-by: Abhishek Mallick <mallickabhishek97@gmail.com>
Copy link
Contributor

@GabrielCTroia GabrielCTroia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small changes and it's good to go! Thank you

libs/movex/package-lock.json Outdated Show resolved Hide resolved
libs/movex/src/lib/client/init.ts Show resolved Hide resolved
@Abhishek-Mallick
Copy link
Contributor Author

Abhishek-Mallick commented Oct 9, 2023

Should now be good
commit: f6dae88

@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 9, 2023
@GabrielCTroia
Copy link
Contributor

GabrielCTroia commented Oct 9, 2023

One last thing:

Your first 2 commits are unsigned and I can't merge, could you please sign them as well!

@GabrielCTroia
Copy link
Contributor

After this your PR will be merged to main! 🙏🚀

@Abhishek-Mallick
Copy link
Contributor Author

I having difficulties verifying the first two commits
The command dosent change anything
Please look through this @GabrielCTroia

@GabrielCTroia GabrielCTroia merged commit ad3a168 into movesthatmatter:main Oct 11, 2023
2 checks passed
@GabrielCTroia
Copy link
Contributor

Hey @Abhishek-Mallick , just merged it! Sorry for the struggle and thank you so much for you effort!

One last thing, could you please star the repo so we can bump it up today for #hacktoberfest!? ❤️🚀🙏

And also, do you have any feedback for the project?

  • did you find it easy to navigate or to understand the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libs/movex] Remove unused initializer
2 participants