Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imported only used methods from fast-json-patch #67

Closed

Conversation

Ekep-Obasi
Copy link
Contributor

Fixes #43

imported only needed methods from fast-json-patch to decrease library size

Checks:

  • the file size decreased
  • all tests pass yarn test

@Ekep-Obasi
Copy link
Contributor Author

@GabrielCTroia I think this is okay now

@GabrielCTroia
Copy link
Contributor

Hey @Ekep-Obasi, thanks for signing the commit. I'm ready to merge it but it seems it has a few small conflicts.

Could you run a git rebase over the updated main and solve those. Then I'm ready to merge! Thanks

@Ekep-Obasi
Copy link
Contributor Author

@GabrielCTroia
I've resolved conflicts

@GabrielCTroia
Copy link
Contributor

Thank you!

It seems the tests are failing though 🤔. Can you please take a look

Screenshot 2023-10-09 at 4 46 29 PM

@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 9, 2023
@Ekep-Obasi
Copy link
Contributor Author

Oh, I see the problem

@Ekep-Obasi Ekep-Obasi reopened this Oct 9, 2023
@Ekep-Obasi Ekep-Obasi closed this Oct 9, 2023
@Ekep-Obasi Ekep-Obasi deleted the imported-only-used-methods branch October 9, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease the library size by importing only needed methods from fast-json-patch
2 participants